Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix: Fixed query auth #1048

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BugFix: Fixed query auth #1048

wants to merge 1 commit into from
+64 −41

Conversation

parmesant
Copy link
Contributor

Auth flow for query and permission assignment for ListStream changed

Fixes #XXXX.

Description

This PR fixes a flaw in the auth flow for the query API
It also changes the Permission for the action ListStream from Unit to Stream which will limit the response of the API to only the streams that the user is allowed to see

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@parmesant
BugFix: Fixed query auth
d18a8d9 
Auth flow for query and permission assignment for `ListStream` changed
@parmesant parmesant requested review from de-sh and nikhilsinhaparseable and removed request for de-sh December 22, 2024 08:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12452845684

Details

  • 0 of 47 (0.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 11.486%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/airplane.rs 0 2 0.0%
src/cli.rs 0 3 0.0%
src/handlers/http/logstream.rs 0 13 0.0%
src/handlers/http/query.rs 0 29 0.0%
Totals Coverage Status
Change from base Build 12441566914: -0.009%
Covered Lines: 2092
Relevant Lines: 18214
💛 - Coveralls

nitisht pushed a commit to parseablehq/console that referenced this pull request Dec 26, 2024
@praveen5959
fix: loading state when stats was error (#396)
9e00783 
Depends on parseablehq/parseable#1048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilsinhaparseable nikhilsinhaparseable Awaiting requested review from nikhilsinhaparseable

@de-sh de-sh Awaiting requested review from de-sh

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parmesant @coveralls